Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notice html distribution #633

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Notice html distribution #633

merged 1 commit into from
Jan 24, 2024

Conversation

CedricGuillemet
Copy link
Contributor

@CedricGuillemet CedricGuillemet commented Jan 23, 2024 •
edited
Loading

Add NOTICE.html from repo root folder inside every npm package next to its readme.
I've run a dry-run publish, checked every .tgz and they all contains the notice file. https://github.com/BabylonJS/BabylonReactNative/actions/runs/7628535866

bghgary
bghgary reviewed Jan 23, 2024
View reviewed changes
Copy link
Contributor

@bghgary bghgary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update this file with the proper contents in a separate change.

@CedricGuillemet CedricGuillemet merged commit c11308e into master Jan 24, 2024
32 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bghgary bghgary bghgary approved these changes

@ryantrem ryantrem Awaiting requested review from ryantrem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CedricGuillemet @bghgary